feat(io): restore the oss scheme with a round trip test and docs - #893
feat(io): restore the oss scheme with a round trip test and docs#893plusplusjiajia wants to merge 1 commit into
Conversation
|
How about still removing oss support from #889 and then you add it back by adding test and documentation to fileio.md to instruct users how to config for oss? |
@wgtmac Works for me — I'll keep this PR and grow it into that: once #889 lands I'll rebase, restore the scheme, and add |
|
#889 has been merged. You may want to proceed with a rebase. |
554a067 to
02a2d21
Compare
plusplusjiajia
changed the title
65e04c5 to
e5c8b9c
Compare
@wgtmac Done — rebased and grown into the restore we discussed: |
e5c8b9c to
dfb372c
Compare
2 participants
Per the suggestion on #889:
osscomes back with a test and documentation.ossreturns tokS3Schemes, which also restores theoss://credential prefix now thatIsS3CredentialPrefixderives from that list. A bareossprefix stays rejected, so nothing widens beyond what main had before #889.CanonicalizeS3Schemenow derives from the same list too — an alias missing there would notfail, it would silently stop matching its credential and fall back to the default one.
rest_arrow_file_io_test.ccand its CMake target are restored; #889 removed them, leavingREST -> ResolvingFileIO -> registry -> Arrow FileIOuncovered. The new test writes, reads back and deletes an object addressed asoss://, againstICEBERG_TEST_S3_URI— the MinIO the AWS jobs already start — and skips whenunset. It passes in 99 ms locally and fails with
URI scheme 'oss' is not supported for FileIO resolutiononceossleaves the scheme table. It proves routing, not credential matching: the same keys also reach the default client through the AWS chain.file-io.mdgains an S3 property table and a section on S3-compatible storage. The OSS example is verified, not transcribed: the signing region iscn-hangzhouwhile the endpoint carries theoss-prefix, and path-style is rejected withSecondLevelDomainForbidden: Please use virtual hosted style to access.